Bug 44554

Summary: Delete LegacyHTMLTreeBuilder
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Adam Barth
Reported 2010-08-24 14:49:26 PDT
Delete LegacyHTMLTreeBuilder
Attachments
Patch (103.56 KB, patch)
2010-08-24 14:50 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-24 14:50:59 PDT
Created attachment 65329 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-24 14:59:58 PDT
Comment on attachment 65329 [details] Patch WebCore/WebCore.xcodeproj/project.pbxproj:  + 512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h in Headers */ = {isa = PBXBuildFile; fileRef = 512DD8EB0D91E6AF000F89EE /* LegacyWebArchive.h */; settings = {ATTRIBUTES = (Private, ); }; }; Looks unintentional. WebCore/WebCore.xcodeproj/project.pbxproj:  + 512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h in Headers */, Looks unintentional. WebCore/dom/Document.cpp:1925 + #ifdef BUILDING_ON_LEOPARD These need a FIXME before them, since the new treebuilder does not support these hacks and (currently) we have no plan to. WebCore/html/HTMLTreeBuilder.cpp:52 + #include <wtf/dtoa.h> You should mark this with a FIXME, no? Otherwise looks fine.
Adam Barth
Comment 3 2010-08-24 15:27:50 PDT
Committed r65941: <http://trac.webkit.org/changeset/65941>
Note You need to log in before you can comment on or make changes to this bug.