Bug 44545

Summary:

[PATCH] Assert that WebKit chromium is not re-initialized

Product:

WebKit

Reporter:

Paweł Hajdan, Jr. <phajdan.jr>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
assertion.patch	fishd: review-, phajdan.jr: commit-queue-
assertion.patch	none

Paweł Hajdan, Jr.

Reported 2010-08-24 12:54:22 PDT

We should assert that WebKit chromium is not re-initialized to prevent crashes like these: http://code.google.com/p/chromium/issues/detail?id=52731 http://code.google.com/p/chromium/issues/detail?id=52643 Please note: the attached patch can not be committed yet, because it will break the chromium tree. I'm just submiting early to get the review done. I will update this bug when the chromium tree is ready to land this patch.

Attachments
assertion.patch (1.38 KB, patch) 2010-08-24 12:55 PDT, Paweł Hajdan, Jr.	fishd: review- phajdan.jr: commit-queue-	Details Formatted Diff Diff
assertion.patch (1.43 KB, patch) 2010-08-24 12:59 PDT, Paweł Hajdan, Jr.	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Paweł Hajdan, Jr.

Comment 1 2010-08-24 12:55:16 PDT

Created attachment 65309 [details] assertion.patch Not ready for commit yet, would break the chromium tree if rolled in.

Darin Fisher (:fishd, Google)

Comment 2 2010-08-24 12:56:59 PDT

Comment on attachment 65309 [details] assertion.patch WebKit/chromium/ChangeLog:5 + Add an assertion to prevent re-initializing WebKit. please add a link here to the webkit bug for this change otherwise, LGTM

Paweł Hajdan, Jr.

Comment 3 2010-08-24 12:59:31 PDT

Created attachment 65310 [details] assertion.patch Fixed review comment. Still not ready for commit.

WebKit Commit Bot

Comment 4 2010-08-25 04:52:55 PDT

Comment on attachment 65310 [details] assertion.patch Clearing flags on attachment: 65310 Committed r66006: <http://trac.webkit.org/changeset/66006>

WebKit Commit Bot

Comment 5 2010-08-25 04:53:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.