Bug 44532

Summary: Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
none
On -> on
pfeldman: review-
+ strings pfeldman: review+

Pavel Podivilov
Reported 2010-08-24 09:46:34 PDT
Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
Attachments
Proposed patch. (14.83 KB, patch)
2010-08-24 09:59 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Proposed patch. (14.70 KB, patch)
2010-08-25 02:58 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
On -> on (14.70 KB, patch)
2010-08-25 03:19 PDT, Pavel Podivilov 		pfeldman: review-
DetailsFormatted DiffDiff
+ strings (15.30 KB, patch)
2010-08-25 03:36 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-08-24 09:59:12 PDT
Created attachment 65287 [details] Proposed patch.
Pavel Feldman
Comment 2 2010-08-24 10:27:11 PDT
Comment on attachment 65287 [details] Proposed patch. LayoutTests/inspector/dom-breakpoints.html:17 + element[name] = value; I think this should be element.setAttribute
Pavel Podivilov
Comment 3 2010-08-25 02:58:47 PDT
Created attachment 65391 [details] Proposed patch.
Pavel Podivilov
Comment 4 2010-08-25 02:59:38 PDT
(In reply to comment #2) > (From update of attachment 65287 [details]) > LayoutTests/inspector/dom-breakpoints.html:17 > + element[name] = value; > I think this should be element.setAttribute done
Pavel Feldman
Comment 5 2010-08-25 03:16:02 PDT
Comment on attachment 65391 [details] Proposed patch. WebCore/inspector/front-end/ElementsTreeOutline.js:769 + contextMenu.appendItem(WebInspector.UIString("Stop On Subtree Modifications"), Stop _on_
Pavel Podivilov
Comment 6 2010-08-25 03:19:07 PDT
Created attachment 65392 [details] On -> on
Pavel Feldman
Comment 7 2010-08-25 03:26:58 PDT
Comment on attachment 65392 [details] On -> on It does not seem to have localized strings changes.
Pavel Podivilov
Comment 8 2010-08-25 03:36:52 PDT
Created attachment 65395 [details] + strings
Pavel Feldman
Comment 9 2010-08-25 05:17:02 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/debugger-test2.js M LayoutTests/http/tests/inspector/inspector-test2.js M LayoutTests/inspector/dom-breakpoints-expected.txt M LayoutTests/inspector/dom-breakpoints.html M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/ElementsTreeOutline.js Committed r66008
Note You need to log in before you can comment on or make changes to this bug.