Bug 44530

Summary:

[Win] No interface definition for WebFrame

Product:

WebKit

Reporter:

Peter Nelson <charn.opcode>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Minor

CC:

abarth, aroben, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Added coclass definition for the WebFrame class	none
Added coclass definition for the WebFrame class (+style fixes :-))	eric: review-

Peter Nelson

Reported 2010-08-24 09:38:35 PDT

Currently there is no coclass definition for the WebFrame class in WebKit/win/Interfaces/WebKit.idl. Without this, the .NET type library importer tool does not appear to import the IWebFramePrivate interface or WebFramePrivate class.

Attachments
Added coclass definition for the WebFrame class (1.05 KB, patch) 2010-08-24 09:45 PDT, Peter Nelson	no flags	Details Formatted Diff Diff
Added coclass definition for the WebFrame class (+style fixes :-)) (1.07 KB, patch) 2010-08-24 10:03 PDT, Peter Nelson	eric: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peter Nelson

Comment 1 2010-08-24 09:45:28 PDT

Created attachment 65285 [details] Added coclass definition for the WebFrame class

WebKit Review Bot

Comment 2 2010-08-24 09:51:49 PDT

Attachment 65285 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/win/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKit/win/Interfaces/WebKit.idl:168: Line contains tab character. [whitespace/tab] [5] WebKit/win/Interfaces/WebKit.idl:169: Line contains tab character. [whitespace/tab] [5] WebKit/win/Interfaces/WebKit.idl:170: Line contains tab character. [whitespace/tab] [5] WebKit/win/Interfaces/WebKit.idl:171: Line contains tab character. [whitespace/tab] [5] WebKit/win/Interfaces/WebKit.idl:172: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Peter Nelson

Comment 3 2010-08-24 10:03:14 PDT

Created attachment 65288 [details] Added coclass definition for the WebFrame class (+style fixes :-))

Adam Barth

Comment 4 2010-08-30 16:45:55 PDT

This seems reasonable, but I don't understand this issue enough to review this patch.

Brian Weinstein

Comment 5 2010-10-13 13:12:26 PDT

Comment on attachment 65288 [details] Added coclass definition for the WebFrame class (+style fixes :-)) View in context: https://bugs.webkit.org/attachment.cgi?id=65288&action=review > WebKit/win/ChangeLog:6 > + Add WebFrame coclass definition to WebKit.idl > + https://bugs.webkit.org/show_bug.cgi?id=44530 It might be nice to explain the benefit of adding the coclass definition here, instead of only having that information in the bug.

Adam Roben (:aroben)

Comment 6 2010-10-13 13:26:26 PDT

We currently only have coclass declarations for classes that we want to allow to be instantiated via CoCreateInstance. WebFrame is not one of those classes. Is there some other way to make it available to .NET?

Eric Seidel (no email)

Comment 7 2010-12-03 13:12:33 PST

Comment on attachment 65288 [details] Added coclass definition for the WebFrame class (+style fixes :-)) Yes, the ChangLog should always explain why.

Note You need to log in before you can comment on or make changes to this bug.