Bug 44501

Summary: Deploy adoptPtr in WebCore/editing
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Severity: Normal CC: commit-queue, darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch commit-queue: commit-queue-

Description Adam Barth 2010-08-24 01:45:46 PDT
Deploy adoptPtr in WebCore/editing
Comment 1 Adam Barth 2010-08-24 01:47:19 PDT
Created attachment 65237 [details]
Comment 2 Adam Barth 2010-08-24 11:37:42 PDT
Comment on attachment 65237 [details]

Clearing flags on attachment: 65237

Committed r65919: <http://trac.webkit.org/changeset/65919>
Comment 3 Adam Barth 2010-08-24 11:37:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2010-08-24 11:41:03 PDT
Comment on attachment 65237 [details]

Rejecting patch 65237 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65237, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
Fetching: https://bugs.webkit.org/show_bug.cgi?id=44501&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 65237 from bug 44501.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Darin Adler 2010-08-24 12:30:16 PDT
The call to clear() seems unneeded.
Comment 6 Adam Barth 2010-08-24 13:31:10 PDT
(In reply to comment #5)
> The call to clear() seems unneeded.

Bug 44548.