Bug 44491

Summary: Deploy adoptPtr in WebCore/storage
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-08-23 23:37:16 PDT
Deploy adoptPtr in WebCore/storage
Attachments
Patch (13.79 KB, patch)
2010-08-23 23:38 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.73 KB, patch)
2010-08-23 23:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-23 23:38:45 PDT
Created attachment 65216 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-23 23:41:17 PDT
Comment on attachment 65216 [details] Patch I'm confused. Were some of these leaks before? Also you use leakPtr, yet you say it's not defined.
Adam Barth
Comment 3 2010-08-23 23:50:20 PDT
Created attachment 65218 [details] Patch
Eric Seidel (no email)
Comment 4 2010-08-23 23:57:22 PDT
Comment on attachment 65218 [details] Patch Using adoptPtr outside of create() seems like a bad idea. I guess you're going to move all this code into create methods next?
Adam Barth
Comment 5 2010-08-24 00:00:00 PDT
Comment on attachment 65218 [details] Patch Yes. This patch is just easier to do first.
Adam Barth
Comment 6 2010-08-24 00:35:07 PDT
Comment on attachment 65218 [details] Patch Clearing flags on attachment: 65218 Committed r65871: <http://trac.webkit.org/changeset/65871>
Adam Barth
Comment 7 2010-08-24 00:35:13 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-08-24 00:53:44 PDT
http://trac.webkit.org/changeset/65871 might have broken Chromium Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/65872 http://trac.webkit.org/changeset/65871
Note You need to log in before you can comment on or make changes to this bug.