Bug 44477

Summary:

HTMLTokenizer::create

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2010-08-23 18:34:58 PDT

HTMLTokenizer::create

Comment 1 Adam Barth 2010-08-23 18:35:57 PDT

Created attachment 65198 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-08-24 13:32:56 PDT

Comment on attachment 65198 [details]
Patch

Can you remove an HTMLTokenizer.h include from WebCore/html/HTMLPreloadScanner.h now?

Can ~HTMLTokenizer() be private since it's always called by RefPtr?

Comment 3 Eric Seidel (no email) 2010-08-24 13:33:25 PDT

Comment on attachment 65198 [details]
Patch

Otherwise LGTM.

Comment 4 Adam Barth 2010-08-24 13:49:32 PDT

Comment on attachment 65198 [details]
Patch

Clearing flags on attachment: 65198

Committed r65932: <http://trac.webkit.org/changeset/65932>

Comment 5 Adam Barth 2010-08-24 13:49:36 PDT

All reviewed patches have been landed.  Closing bug.