Bug 44477

Summary: HTMLTokenizer::create
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-08-23 18:34:58 PDT
HTMLTokenizer::create
Attachments
Patch (7.74 KB, patch)
2010-08-23 18:35 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-23 18:35:57 PDT
Created attachment 65198 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-24 13:32:56 PDT
Comment on attachment 65198 [details] Patch Can you remove an HTMLTokenizer.h include from WebCore/html/HTMLPreloadScanner.h now? Can ~HTMLTokenizer() be private since it's always called by RefPtr?
Eric Seidel (no email)
Comment 3 2010-08-24 13:33:25 PDT
Comment on attachment 65198 [details] Patch Otherwise LGTM.
Adam Barth
Comment 4 2010-08-24 13:49:32 PDT
Comment on attachment 65198 [details] Patch Clearing flags on attachment: 65198 Committed r65932: <http://trac.webkit.org/changeset/65932>
Adam Barth
Comment 5 2010-08-24 13:49:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.