Summary: | [GTK] ScrollbarThemeGtk is incomplete | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2010-08-23 17:29:20 PDT
Created attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars
Comment on attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars
LGTM. The only thing that looks problematic to me is this:
56 // We do not support multiple steppers per end yet.
57 if (part == BackButtonEndPart)
58 return IntRect();
Though we don't seem to be regressing from our previous state, and thankfully themes sporting more than one button per side seem to have gone out of fashion =).
Committed r66148: <http://trac.webkit.org/changeset/66148> |