Bug 44471

Summary: [GTK] ScrollbarThemeGtk is incomplete
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Add theme-based painting for GTK+ scrollbars gustavo: review+

Description Martin Robinson 2010-08-23 17:29:20 PDT 
Currently, interior frame scrollbars are native widgets, which leads to a lot of mysterious code in ScrollbarGtk. It also means that for WebKit2 mouse click need to be routed through GTK+ instead of directly through WebCore. The first step in making fully-fake interior scrollbars is to complete ScrollbarThemeGtk via the Mozilla theming API. The bug tracks that work.
Comment 1 Martin Robinson 2010-08-23 17:48:13 PDT 
Created attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars
Comment 2 Gustavo Noronha (kov) 2010-08-26 06:54:24 PDT 
Comment on attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars

LGTM. The only thing that looks problematic to me is this:

 56     // We do not support multiple steppers per end yet.
 57     if (part == BackButtonEndPart)
 58         return IntRect();

Though we don't seem to be regressing from our previous state, and thankfully themes sporting more than one button per side seem to have gone out of fashion =).
Comment 3 Martin Robinson 2010-08-26 16:14:33 PDT 
Committed r66148: <http://trac.webkit.org/changeset/66148>