Bug 44455

Summary:

Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, dglazkov, jamesr, senorblanco, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	dglazkov: review+, kbr: commit-queue-

Description Kenneth Russell 2010-08-23 14:01:47 PDT

The fact that GraphicsContext3D references the ArrayBuffer and ArrayBufferView types makes it difficult to reuse outside of WebGL, and is also a layering violation. GraphicsContext3D should refer only to void* (and a size argument) in these situations.

Comment 1 Kenneth Russell 2010-08-23 15:52:25 PDT

Created attachment 65168 [details]
Patch

From the ChangeLog:

Updated Safari, Qt and Chromium WebGL ports to avoid referencing ArrayBuffer and ArrayBufferView types from GraphicsContext3D. Ran all WebGL layout tests; no new regressions. Built and tested WebKit on Mac OS X; built Chromium on Mac OS X and Linux.

Comment 2 Dimitri Glazkov (Google) 2010-08-23 15:59:37 PDT

Comment on attachment 65168 [details]
Patch

ok.

Comment 3 Kenneth Russell 2010-08-23 16:07:37 PDT

Committed r65839: <http://trac.webkit.org/changeset/65839>