Bug 44451

Summary: REGRESSION(r65812): Broke fast/events/special-key-events-in-input-text.html for chromium (Requested by jamesr on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, jamesr, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44156    
Attachments:
Description Flags
ROLLOUT of r65812 none

Description WebKit Review Bot 2010-08-23 12:53:40 PDT
http://trac.webkit.org/changeset/65812 broke the build:
Broke fast/events/special-key-events-in-input-text.html for chromium (Requested by jamesr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-23 12:53:57 PDT
Created attachment 65155 [details]
ROLLOUT of r65812

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 James Robinson 2010-08-23 13:22:37 PDT
Comment on attachment 65155 [details]
ROLLOUT of r65812

clearing c-q, will land by hand. commit queue seems broken.
Comment 3 James Robinson 2010-08-23 13:44:05 PDT
Committed r65829: <http://trac.webkit.org/changeset/65829>
Comment 4 Eric Seidel (no email) 2010-08-23 14:28:40 PDT
Can you be more specific? :)  The cq does not run tests on rollouts, no:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py#L215

But it might have been fighting an out-of-date checkout.
Comment 5 James Robinson 2010-08-23 14:32:01 PDT
The commit queue status page said "Unable to successfully build and test".  I didn't see any way to get more information so I don't know what it was trying or failing to do.
Comment 6 Eric Seidel (no email) 2010-08-23 14:38:03 PDT
Maybe I'll get around to landing bug 41820 finally. :(