Bug 44428

Summary:

Get basic in-process windowed plugins working in WebKit2 on Windows

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, jhoneycutt, sam

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Bug Depends on:

46409, 46470, 46502, 46510, 46512

Bug Blocks:

Attachments:

Description	Flags
Patch	andersca: review+

Adam Roben (:aroben)

Reported 2010-08-23 08:34:42 PDT

This is an umbrella bug for tracking progress on getting in-process windowed plugins working in WebKit2 on Windows (windowless plugins were covered by bug 43189). Once we're able to play some simple Flash videos (e.g., on YouTube) we'll close this bug out.

Attachments
Patch (10.43 KB, patch) 2010-09-24 14:56 PDT, Adam Roben (:aroben)	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2010-08-23 08:35:51 PDT

<rdar://problem/8341812>

Adam Roben (:aroben)

Comment 2 2010-09-24 14:56:08 PDT

Created attachment 68758 [details] Patch

Adam Roben (:aroben)

Comment 3 2010-09-24 15:00:33 PDT

Comment on attachment 68758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68758&action=review > WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:374 > { > ASSERT(m_isStarted); > > + platformDestroy(); > + > // Stop all streams. > stopAllStreams(); > After talking with Anders, I'm going to move the call to platformDestroy() after the call to NPP_Destroy. That matches what WebKit1 did.

Adam Roben (:aroben)

Comment 4 2010-09-24 15:15:22 PDT

Committed r68299: <http://trac.webkit.org/changeset/68299>

Note You need to log in before you can comment on or make changes to this bug.