Summary: | WebCore/bridge/jni/v8 does not compile | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Iain Merrick <husky> | ||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, commit-queue, steveblock | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Iain Merrick
2010-08-23 06:37:47 PDT
Created attachment 65111 [details]
Patch to make V8 strings compile
Comment on attachment 65111 [details]
Patch to make V8 strings compile
If you'd like the patch to be reviewed, you should set the r? flag. This will make the patch show up in the review queue and trigger the EWS bots.
As a non-committer, you probably want to set cq? too, to request the reviewer to add the patch to the commit-queue once reviewed.
Comment on attachment 65111 [details]
Patch to make V8 strings compile
WebCore/ChangeLog:5
+ Make V8 string wrappers compatible with JavaScriptCore/runtime/UString.h
I think this title is a little confusing. We're fixing the JNI bridge for V8. The problem is that the declaration of JavaString has been changed but the V8 implementation was not updated. Maybe 'Update JNI bridge for V8 after renaming of JavaString::utf8()'
Created attachment 65118 [details]
Patch to make V8 strings compile
Modified ChangeLog per steveblock's comment
Comment on attachment 65118 [details]
Patch to make V8 strings compile
r=me
Comment on attachment 65118 [details] Patch to make V8 strings compile Clearing flags on attachment: 65118 Committed r65833: <http://trac.webkit.org/changeset/65833> All reviewed patches have been landed. Closing bug. |