Bug 44363

Summary:

Add tests for FileWriter

Product:

WebKit

Reporter:

Eric U. <ericu>

Component:

WebCore Misc.

Assignee:

Eric U. <ericu>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

abarth, commit-queue, dbates, dglazkov, eric, kinuko, michaeln, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

44358

Attachments:

Description	Flags
Patch	levin: review+, commit-queue: commit-queue-
Second try--same patch, but removed one potential conflict that had already been checked in.	commit-queue: commit-queue-
Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify.	commit-queue: commit-queue-

Eric U.

Reported 2010-08-20 14:46:45 PDT

Add layout tests for the FileWriter DOM object.

Attachments
Patch (29.76 KB, patch) 2010-12-10 15:28 PST, Eric U.	levin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Second try--same patch, but removed one potential conflict that had already been checked in. (26.64 KB, patch) 2011-02-15 13:00 PST, Eric U.	commit-queue: commit-queue-	Details Formatted Diff Diff
Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify. (26.33 KB, patch) 2011-02-15 15:07 PST, Eric U.	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric U.

Comment 1 2010-12-10 15:28:07 PST

Created attachment 76269 [details] Patch

WebKit Commit Bot

Comment 2 2011-02-14 13:26:00 PST

Comment on attachment 76269 [details] Patch Rejecting attachment 76269 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2 Last 500 characters of output: esystem/workers/file-writer-events.html patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7909691

Eric U.

Comment 3 2011-02-14 15:11:57 PST

The CQ's output actually doesn't show any indication of what the problem might be. I'm going to upload an updated patch [svn update, fix up changelog, re-upload] and see how that goes.

Eric Seidel (no email)

Comment 4 2011-02-14 15:45:29 PST

Yes, unfortunately that's true for when svn-apply fais. That regressed many months ago and we never fixed it. :(

Eric U.

Comment 5 2011-02-15 13:00:22 PST

Created attachment 82511 [details] Second try--same patch, but removed one potential conflict that had already been checked in.

WebKit Commit Bot

Comment 6 2011-02-15 13:56:00 PST

Comment on attachment 82511 [details] Second try--same patch, but removed one potential conflict that had already been checked in. Rejecting attachment 82511 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2 Last 500 characters of output: . Processing patch 82511 from bug 44363. Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2 Parsed 18 diffs from patch file(s). cp: fast/filesystem/file-writer-gc-blob.html: No such file or directory Failed to copy fast/filesystem/file-writer-gc-blob.html fast/filesystem/resources/file-writer-gc-blob.js. at /Projects/CommitQueue/Tools/Scripts/svn-apply line 427. Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/7910992

Eric U.

Comment 7 2011-02-15 15:07:10 PST

Created attachment 82531 [details] Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify.

WebKit Commit Bot

Comment 8 2011-02-15 15:25:55 PST

Comment on attachment 82531 [details] Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify. Rejecting attachment 82531 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: ile LayoutTests/fast/filesystem/workers/file-writer-events.html patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7918054

Eric U.

Comment 9 2011-03-11 15:46:39 PST

Manually committed r80896: http://trac.webkit.org/changeset/80896.

WebKit Review Bot

Comment 10 2011-03-11 17:13:22 PST

http://trac.webkit.org/changeset/80904 might have broken Chromium Win Release

Note You need to log in before you can comment on or make changes to this bug.