Bug 44353

Summary: Do Not Copy Subversion Related Files in Inspector Build Phase
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, joepeck, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Remove .svn directories
ddkilzer: review+
[SCRIPT] Build Phase - Not One Line none

Description Joseph Pecoraro 2010-08-20 13:57:25 PDT 
`ditto` does a dumb copy in the "Copy Inspector Resources" build phase.
Let me know if you think I should switch over to an `rsync --exclude`
implementation like the "Copy Forwarding and ICU Headers" build phase.
Comment 1 Joseph Pecoraro 2010-08-20 13:59:32 PDT 
Created attachment 64990 [details]
[PATCH] Remove .svn directories

Adds the following:

    # Remove any .svn directories that may have been copied over.
    find "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector" -name ".svn" -type d | xargs rm -r
Comment 2 Joseph Pecoraro 2010-08-20 14:00:22 PDT 
Created attachment 64991 [details]
[SCRIPT] Build Phase - Not One Line

This is what the Build Phase looks like, not in one line.
Comment 3 David Kilzer (:ddkilzer) 2010-08-20 14:06:52 PDT 
Comment on attachment 64990 [details]
[PATCH] Remove .svn directories

WebCore/WebCore.xcodeproj/project.pbxproj:20491
+ [...]find \"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\" -name \".svn\" -type d | xargs rm -r\n";

I would actually use "rm -rf" here to force the deletion (unless you want the script to complain if rm doesn't work).

r=me either way.
Comment 4 Joseph Pecoraro 2010-08-20 14:17:44 PDT 
> I would actually use "rm -rf" here [...]

Done. Each of the other `rm -rf`

Committed r65753
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
r65753 = 75779b62fce9cf44123d6ace17d73db0d307f98a (refs/remotes/trunk)
http://trac.webkit.org/changeset/65753