Bug 44327

Summary:

Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch.	pfeldman: review-
Proposed patch.	none

Pavel Podivilov

Reported 2010-08-20 02:17:34 PDT

Web Inspector: remove breakpoint specific code from BreakpointSidebarPane

Attachments
Proposed patch. (16.56 KB, patch) 2010-08-20 02:46 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
Proposed patch. (16.55 KB, patch) 2010-08-20 06:58 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2010-08-20 02:46:16 PDT

Created attachment 64939 [details] Proposed patch.

Pavel Feldman

Comment 2 2010-08-20 05:07:34 PDT

Comment on attachment 64939 [details] Proposed patch. WebCore/inspector/front-end/BreakpointsSidebarPane.js:86 + WebInspector.BreakpointElement = function(breakpoint) Please rename WebInspector.BreakpointElement => WebInspector.JSBreakpointItem. Otherwise looks good.

Pavel Podivilov

Comment 3 2010-08-20 06:58:30 PDT

Created attachment 64953 [details] Proposed patch.

WebKit Commit Bot

Comment 4 2010-08-23 07:41:24 PDT

Comment on attachment 64953 [details] Proposed patch. Clearing flags on attachment: 64953 Committed r65810: <http://trac.webkit.org/changeset/65810>

WebKit Commit Bot

Comment 5 2010-08-23 07:41:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.