Bug 44315

Summary: HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: HistoryAssignee: Mihai Parparita <mihaip>
Severity: Normal CC: beidson, commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Mihai Parparita 2010-08-19 17:31:56 PDT
It looks like the HISTORY_ALWAYS_ASYNC #define was added for bug 33538. At that point there was some debate as to the intent of the HTML5 spec. However, it looks like there was a WHATWG thread to discuss this (http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-January/thread.html#24786) and the outcome was that the spec now says "To traverse the history by a delta delta, the user agent must queue a task to run the following steps. " (from http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history-by-a-delta)

Brady, I realize that you were opposed to this change initially. Given that the spec has been updated (as as far as I can tell, no existing layout tests depend on navigation being synchronous), would you be OK with it now?
Comment 1 Mihai Parparita 2010-08-24 14:04:32 PDT
Created attachment 65319 [details]
Comment 2 Mihai Parparita 2010-08-24 14:25:04 PDT
Comment on attachment 65319 [details]

Actually, fast/dom/location-hash.html fails with this change. I'll need to update that too.
Comment 3 Brady Eidson 2010-08-24 14:38:08 PDT
Wonder what the change to that test will be.
Comment 4 Mihai Parparita 2010-08-24 14:47:28 PDT
Created attachment 65328 [details]
Comment 5 Mihai Parparita 2010-08-24 14:50:37 PDT
(In reply to comment #3)
> Wonder what the change to that test will be.

It's basically reverting the changes to the test made by r53950. With my changes the test won't pass if traversal is synchronous, if you'd like I can make it pass with either sync or async traversal (since there's an separatel explicit test for async behavior).
Comment 6 Adam Barth 2010-08-30 16:49:09 PDT
Comment on attachment 65328 [details]

Following HTML5 is a good idea.  Brady, feel free to let us know if you're still opposed to this patch.
Comment 7 WebKit Commit Bot 2010-08-30 22:39:59 PDT
Comment on attachment 65328 [details]

Clearing flags on attachment: 65328

Committed r66458: <http://trac.webkit.org/changeset/66458>
Comment 8 WebKit Commit Bot 2010-08-30 22:40:03 PDT
All reviewed patches have been landed.  Closing bug.