Summary: | HISTORY_ALWAYS_ASYNC should be removed (history should always be async) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||||
Component: | History | Assignee: | Mihai Parparita <mihaip> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, fishd | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mihai Parparita
2010-08-19 17:31:56 PDT
Created attachment 65319 [details]
Patch
Comment on attachment 65319 [details]
Patch
Actually, fast/dom/location-hash.html fails with this change. I'll need to update that too.
Wonder what the change to that test will be. Created attachment 65328 [details]
Patch
(In reply to comment #3) > Wonder what the change to that test will be. It's basically reverting the changes to the test made by r53950. With my changes the test won't pass if traversal is synchronous, if you'd like I can make it pass with either sync or async traversal (since there's an separatel explicit test for async behavior). Comment on attachment 65328 [details]
Patch
Following HTML5 is a good idea. Brady, feel free to let us know if you're still opposed to this patch.
Comment on attachment 65328 [details] Patch Clearing flags on attachment: 65328 Committed r66458: <http://trac.webkit.org/changeset/66458> All reviewed patches have been landed. Closing bug. |