Bug 44298

Summary: Failing the download step should make the build red
Product: WebKit Reporter: James Robinson <jamesr>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2010-08-19 15:00:16 PDT
Currently if a test slave's download step fails the build does not go red. This makes it seems like the tests pass on the console view, which is quite dangerous. For example on a recent run of the SnowLeopard Intel Release (WebKit2 tests) bot the download step failed with this stderr: "File 'archives/mac-snowleopard-x86_64-release/65706.zip' not available at master", but the results of the build was "build successful". http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/265
Attachments
Patch (1.45 KB, patch)
2010-08-29 19:01 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
William Siegrist
Comment 1 2010-08-19 15:04:01 PDT
FileUpload and FileDownload steps default to not flunking the whole build if they fail. This should be just a 1 line change to add flunkOnFailure=True to DownloadBuiltProduct.
James Robinson
Comment 2 2010-08-29 19:01:28 PDT
Created attachment 65869 [details] Patch
WebKit Commit Bot
Comment 3 2010-08-29 21:26:22 PDT
Comment on attachment 65869 [details] Patch Clearing flags on attachment: 65869 Committed r66353: <http://trac.webkit.org/changeset/66353>
WebKit Commit Bot
Comment 4 2010-08-29 21:26:26 PDT
All reviewed patches have been landed. Closing bug.
William Siegrist
Comment 5 2010-08-30 08:40:42 PDT
Updated master. Graceful restart process has been kicked off.
Note You need to log in before you can comment on or make changes to this bug.