Bug 44294

Summary:

After r65681, caret no longer displays promptly while editing form fields

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

HTML Editing

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, enrica, eric, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Bug Depends on:

21834

Bug Blocks:

44290

Attachments:

Description	Flags
Patch	tony: review+

Description Simon Fraser (smfr) 2010-08-19 14:39:14 PDT

r65681 caused the caret to use the last-computed caret rect when painting, rather than forcing a style update. That seems to have changed the drawing of the caret in the middle of editing. This testcase shows a pixel difference as a result:

fast/forms/input-text-scroll-left-on-blur.html

Comment 1 Simon Fraser (smfr) 2010-08-19 15:03:53 PDT

Hmm, this only seems to be when you hit the end of the field and start to scroll.

Comment 2 Simon Fraser (smfr) 2010-08-20 09:53:36 PDT

<rdar://problem/8335354>

Comment 3 Simon Fraser (smfr) 2010-08-20 14:46:42 PDT

Created attachment 64995 [details]
Patch

Comment 4 Enrica Casucci 2010-08-23 08:50:38 PDT

This looks good to me.

Comment 5 Simon Fraser (smfr) 2010-08-24 14:02:10 PDT

http://trac.webkit.org/changeset/65934

Comment 6 WebKit Review Bot 2010-08-24 14:46:46 PDT

http://trac.webkit.org/changeset/65934 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/65933
http://trac.webkit.org/changeset/65934