Bug 44273

Summary: Web Inspector: fall back to object formatting in case dom is not yet loaded.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
none
[PATCH] Proposed change. none

Pavel Feldman
Reported 2010-08-19 10:30:59 PDT
Sometimes DOM is loaded after the inline message is being formatted, so we get no nodeId for it. Let us fall back to object formatting in such cases. Patch to follow.
Attachments
[PATCH] Proposed change. (2.54 KB, patch)
2010-08-19 10:32 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed change. (1.96 KB, patch)
2010-08-19 10:34 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-19 10:32:53 PDT
Created attachment 64868 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2010-08-19 10:34:26 PDT
Comment on attachment 64868 [details] [PATCH] Proposed change. WebCore/ChangeLog:10 + Patch to follow. Remove this from changelog. WebCore/inspector/front-end/ConsoleView.js:663 + console.log(JSON.stringify(parameters)); Remove this as well.
Pavel Feldman
Comment 3 2010-08-19 10:34:40 PDT
Created attachment 64869 [details] [PATCH] Proposed change.
Eric Seidel (no email)
Comment 4 2010-12-20 22:30:42 PST
Comment on attachment 64869 [details] [PATCH] Proposed change. Looks abandoned. Maybe it never got committed?
WebKit Commit Bot
Comment 5 2010-12-20 23:25:42 PST
Comment on attachment 64869 [details] [PATCH] Proposed change. Clearing flags on attachment: 64869 Committed r74399: <http://trac.webkit.org/changeset/74399>
WebKit Commit Bot
Comment 6 2010-12-20 23:25:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.