Bug 44269

Summary: NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 43189    
Attachments:
Description Flags
Patch sam: review+

Description Adam Roben (:aroben) 2010-08-19 09:06:33 PDT 
NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp
Comment 1 Adam Roben (:aroben) 2010-08-19 09:07:23 PDT 
Created attachment 64861 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-19 09:09:51 PDT 
Attachment 64861 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-08-19 11:06:05 PDT 
<rdar://problem/8330391>
Comment 4 Adam Roben (:aroben) 2010-08-19 14:26:31 PDT 
Committed r65702: <http://trac.webkit.org/changeset/65702>