Bug 44269 - NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp
Summary: NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 43189
  Show dependency tree / graph
 
Reported: 2010-08-19 09:06 PDT by Adam Roben (:aroben)
Modified: 2010-08-19 16:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.75 KB, patch)
2010-08-19 09:07 PDT, Adam Roben (:aroben) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-08-19 09:06:33 PDT 
NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp
Comment 1 Adam Roben (:aroben) 2010-08-19 09:07:23 PDT 
Created attachment 64861 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-19 09:09:51 PDT 
Attachment 64861 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-08-19 11:06:05 PDT 
<rdar://problem/8330391>
Comment 4 Adam Roben (:aroben) 2010-08-19 14:26:31 PDT 
Committed r65702: <http://trac.webkit.org/changeset/65702>