Bug 44264

Summary: Remove IDBDatabase.description per spec changes
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, bulach, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch steveblock: review+

Jeremy Orlow
Reported 2010-08-19 07:49:18 PDT
Remove IDBDatabase.description per spec changes
Attachments
Patch (16.36 KB, patch)
2010-08-19 07:52 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (16.00 KB, patch)
2010-08-23 04:54 PDT, Jeremy Orlow 		steveblock: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-08-19 07:52:58 PDT
Created attachment 64852 [details] Patch
Steve Block
Comment 2 2010-08-23 03:17:18 PDT
Comment on attachment 64852 [details] Patch WebCore/manual-tests/indexed-database.html:53 + function step3() Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places?
Jeremy Orlow
Comment 3 2010-08-23 04:29:00 PDT
(In reply to comment #2) > (From update of attachment 64852 [details]) > WebCore/manual-tests/indexed-database.html:53 > + function step3() > Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places? It is. I can do that. Any other comments?
Andrei Popescu
Comment 4 2010-08-23 04:32:41 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 64852 [details] [details]) > > WebCore/manual-tests/indexed-database.html:53 > > + function step3() > > Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places? > > It is. I can do that. Any other comments? LGTM
Jeremy Orlow
Comment 5 2010-08-23 04:54:39 PDT
Created attachment 65102 [details] Patch
Steve Block
Comment 6 2010-08-23 05:37:44 PDT
Comment on attachment 65102 [details] Patch r=me
Jeremy Orlow
Comment 7 2010-08-23 06:23:25 PDT
Committed r65807: <http://trac.webkit.org/changeset/65807>
Note You need to log in before you can comment on or make changes to this bug.