Bug 44249

Summary: compilation issue with JSTimeRanges when video turned off
Product: WebKit Reporter: zaheer <zaheer.mot>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed patch darin: review+

Description zaheer 2010-08-19 04:55:47 PDT
Error in generated code
DerivedSources/WebCore/JSDOMWindow.cpp:343:26: error: JSTimeRanges.h: No such file or directory

The fix could be
a) move JSTimeRanges.* outside ENABLE_VIDEO like JSHTMLVideoElement.* which is not specific to video
b) change CodeGenerator.pm to generate the #if ENABLE(*) for implIncludes. This will impact all other headers so iam inclined towards 1.
Comment 1 zaheer 2010-08-19 05:25:24 PDT
Created attachment 64833 [details]
Proposed patch
Comment 2 zaheer 2010-08-26 00:14:22 PDT
Xan, this is one more build error with video off Thx
Comment 3 zaheer 2010-09-02 10:49:15 PDT
Thanks Darin, could you pls do a commit-queue+
Comment 4 Julien Chaffraix 2010-09-03 09:16:31 PDT
Landed in r66736.