Bug 44249 - compilation issue with JSTimeRanges when video turned off
Summary: compilation issue with JSTimeRanges when video turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 04:55 PDT by zaheer
Modified: 2010-09-03 09:16 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.47 KB, patch)
2010-08-19 05:25 PDT, zaheer 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zaheer 2010-08-19 04:55:47 PDT 
Error in generated code
DerivedSources/WebCore/JSDOMWindow.cpp:343:26: error: JSTimeRanges.h: No such file or directory

The fix could be
a) move JSTimeRanges.* outside ENABLE_VIDEO like JSHTMLVideoElement.* which is not specific to video
b) change CodeGenerator.pm to generate the #if ENABLE(*) for implIncludes. This will impact all other headers so iam inclined towards 1.
Comment 1 zaheer 2010-08-19 05:25:24 PDT 
Created attachment 64833 [details]
Proposed patch
Comment 2 zaheer 2010-08-26 00:14:22 PDT 
Xan, this is one more build error with video off Thx
Comment 3 zaheer 2010-09-02 10:49:15 PDT 
Thanks Darin, could you pls do a commit-queue+
Comment 4 Julien Chaffraix 2010-09-03 09:16:31 PDT 
Landed in r66736.