RESOLVED FIXED 44249
compilation issue with JSTimeRanges when video turned off 
https://bugs.webkit.org/show_bug.cgi?id=44249
Summary compilation issue with JSTimeRanges when video turned off
zaheer
Reported 2010-08-19 04:55:47 PDT
Error in generated code DerivedSources/WebCore/JSDOMWindow.cpp:343:26: error: JSTimeRanges.h: No such file or directory The fix could be a) move JSTimeRanges.* outside ENABLE_VIDEO like JSHTMLVideoElement.* which is not specific to video b) change CodeGenerator.pm to generate the #if ENABLE(*) for implIncludes. This will impact all other headers so iam inclined towards 1.
Attachments
Proposed patch (1.47 KB, patch)
2010-08-19 05:25 PDT, zaheer 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zaheer
Comment 1 2010-08-19 05:25:24 PDT
Created attachment 64833 [details] Proposed patch
zaheer
Comment 2 2010-08-26 00:14:22 PDT
Xan, this is one more build error with video off Thx
zaheer
Comment 3 2010-09-02 10:49:15 PDT
Thanks Darin, could you pls do a commit-queue+
Julien Chaffraix
Comment 4 2010-09-03 09:16:31 PDT
Landed in r66736.
Note You need to log in before you can comment on or make changes to this bug.