Bug 44236

Summary: GTK port doesnt compile with video turned off
Product: WebKit Reporter: zaheer <zaheer.mot>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed patch
xan.lopez: review-
Updated Patch none

Description zaheer 2010-08-19 02:19:24 PDT 
compilation error in WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp with video turned off. Attaching possible patch.
Comment 1 zaheer 2010-08-19 02:39:51 PDT 
Created attachment 64824 [details]
Proposed patch
Comment 2 Xan Lopez 2010-08-20 01:49:04 PDT 
Comment on attachment 64824 [details]
Proposed patch

This is not enough, you also need to disable the generation of the API files. Check in the main GNUMakefile.am how the geolocation stuff is made conditional.

Also, I think the preferred style for conditional headers is to put them after all the unconditional ones.
Comment 3 zaheer 2010-08-21 02:53:55 PDT 
Created attachment 65024 [details]
Updated Patch
Comment 4 Xan Lopez 2010-08-21 02:57:13 PDT 
Comment on attachment 65024 [details]
Updated Patch

Fantastic, thank you.
Comment 5 zaheer 2010-08-22 22:58:52 PDT 
(In reply to comment #4)
> (From update of attachment 65024 [details])
> Fantastic, thank you.
Thank you. Could you push to the commit queue.
Comment 6 Xan Lopez 2010-08-25 05:17:56 PDT 
Comment on attachment 65024 [details]
Updated Patch

Forgot to set cq+
Comment 7 WebKit Commit Bot 2010-08-25 06:08:50 PDT 
Comment on attachment 65024 [details]
Updated Patch

Clearing flags on attachment: 65024

Committed r66009: <http://trac.webkit.org/changeset/66009>
Comment 8 WebKit Commit Bot 2010-08-25 06:08:55 PDT 
All reviewed patches have been landed.  Closing bug.