Bug 44236

Summary: GTK port doesnt compile with video turned off
Product: WebKit Reporter: zaheer <zaheer.mot>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed patch
xan.lopez: review-
Updated Patch none

zaheer
Reported 2010-08-19 02:19:24 PDT
compilation error in WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp with video turned off. Attaching possible patch.
Attachments
Proposed patch (2.12 KB, patch)
2010-08-19 02:39 PDT, zaheer 		xan.lopez: review-
DetailsFormatted DiffDiff
Updated Patch (4.00 KB, patch)
2010-08-21 02:53 PDT, zaheer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zaheer
Comment 1 2010-08-19 02:39:51 PDT
Created attachment 64824 [details] Proposed patch
Xan Lopez
Comment 2 2010-08-20 01:49:04 PDT
Comment on attachment 64824 [details] Proposed patch This is not enough, you also need to disable the generation of the API files. Check in the main GNUMakefile.am how the geolocation stuff is made conditional. Also, I think the preferred style for conditional headers is to put them after all the unconditional ones.
zaheer
Comment 3 2010-08-21 02:53:55 PDT
Created attachment 65024 [details] Updated Patch
Xan Lopez
Comment 4 2010-08-21 02:57:13 PDT
Comment on attachment 65024 [details] Updated Patch Fantastic, thank you.
zaheer
Comment 5 2010-08-22 22:58:52 PDT
(In reply to comment #4) > (From update of attachment 65024 [details]) > Fantastic, thank you. Thank you. Could you push to the commit queue.
Xan Lopez
Comment 6 2010-08-25 05:17:56 PDT
Comment on attachment 65024 [details] Updated Patch Forgot to set cq+
WebKit Commit Bot
Comment 7 2010-08-25 06:08:50 PDT
Comment on attachment 65024 [details] Updated Patch Clearing flags on attachment: 65024 Committed r66009: <http://trac.webkit.org/changeset/66009>
WebKit Commit Bot
Comment 8 2010-08-25 06:08:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.