Bug 44232

Summary:

[Qt] Avoid unnecessary string copy in TextCodecQt::decode()

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Text

Assignee:

QtWebKit Unassigned <webkit-qt-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Performance, Qt, QtTriaged

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Description Andreas Kling 2010-08-19 00:39:30 PDT

The string returned by QTextCodec::toUnicode() is unnecessarily copied before it's appended to the return value.

Comment 1 Andreas Kling 2010-08-19 00:41:52 PDT

Created attachment 64815 [details]
Proposed patch

Comment 2 Andreas Kling 2010-08-19 01:16:10 PDT

Comment on attachment 64815 [details]
Proposed patch

Clearing flags on attachment: 64815

Committed r65659: <http://trac.webkit.org/changeset/65659>

Comment 3 Andreas Kling 2010-08-19 01:16:21 PDT

All reviewed patches have been landed.  Closing bug.