Bug 44224

Summary: Move FileStreamClient to platform and add AsyncFileStream interface
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, fishd, kinuko, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
jianli: commit-queue-
Proposed Patch
jianli: commit-queue-
Proposed Patch levin: review+, jianli: commit-queue-

Jian Li
Reported 2010-08-18 17:35:08 PDT
Move FileStreamClient to platform and add AsyncFileStream interface. This is needed by BlobResounceHandle that is put under platform/network.
Attachments
Proposed Patch (23.10 KB, patch)
2010-08-18 17:38 PDT, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (23.10 KB, patch)
2010-08-18 17:42 PDT, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (23.18 KB, patch)
2010-08-18 18:59 PDT, Jian Li 		levin: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-08-18 17:38:47 PDT
Created attachment 64794 [details] Proposed Patch
WebKit Review Bot
Comment 2 2010-08-18 17:40:16 PDT
Attachment 64794 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/AsyncFileStream.h:59: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jian Li
Comment 3 2010-08-18 17:42:15 PDT
Created attachment 64795 [details] Proposed Patch Fixed style error.
Jian Li
Comment 4 2010-08-18 18:59:09 PDT
Created attachment 64798 [details] Proposed Patch
Jian Li
Comment 5 2010-08-20 11:35:29 PDT
Committed as http://trac.webkit.org/changeset/65745.
Note You need to log in before you can comment on or make changes to this bug.