Bug 44218
| Summary: | run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Major | CC: | abarth, adamk, ap, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac (Intel) | ||
| OS: | OS X 10.5 | ||
Ryosuke Niwa
run-webkit-tests's pretty diff currently does not support non-ASCII characters. As a result, non-ASCII characters such as those used to test RTL texts are corrupted in the expected results when the test uses dumpAsText. Try editing/text-iterator/rtl-selection-crash.html for example.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
FYI: diffs have no encoding and must be treated as binary.
Alexey Proskuryakov
Actually, I think that expected results are always UTF-8.
Adam Klein
Just wasted some time due to this; haven't ever looked at pretty diff, how hard is this to fix?