Bug 44218

Summary: run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Major CC: abarth, adamk, ap, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   

Description Ryosuke Niwa 2010-08-18 16:57:50 PDT
run-webkit-tests's pretty diff currently does not support non-ASCII characters.  As a result, non-ASCII characters such as those used to test RTL texts are corrupted in the expected results when the test uses dumpAsText.  Try editing/text-iterator/rtl-selection-crash.html for example.
Comment 1 Eric Seidel (no email) 2010-08-18 17:34:34 PDT
FYI: diffs have no encoding and must be treated as binary.
Comment 2 Alexey Proskuryakov 2010-08-20 10:37:35 PDT
Actually, I think that expected results are always UTF-8.
Comment 3 Adam Klein 2012-10-19 15:15:10 PDT
Just wasted some time due to this; haven't ever looked at pretty diff, how hard is this to fix?