Bug 44205

Summary:

[Chromium] Add Full screen item to video context menu

Product:

WebKit

Reporter:

Bo Liu <boliu>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

boliu, scherkus

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Update comment to FIXME	abarth: review-

Bo Liu

Reported 2010-08-18 14:49:07 PDT

Corresponding Chromium patch: http://codereview.chromium.org/3124032 Adds a Fullscreen WebMediaPlayerAction.

Attachments
Patch (1.20 KB, patch) 2010-08-18 14:58 PDT, Bo Liu	no flags	Details Formatted Diff Diff
Update comment to FIXME (1.22 KB, patch) 2010-08-19 11:30 PDT, Bo Liu	abarth: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Bo Liu

Comment 1 2010-08-18 14:58:43 PDT

Created attachment 64778 [details] Patch

Andrew Scherkus

Comment 2 2010-08-19 09:46:06 PDT

Comment on attachment 64778 [details] Patch WebKit/chromium/src/WebViewImpl.cpp:1516 + // Bring full screen window into focus if isFullscreen. is this a TODO or leftover comment?

Bo Liu

Comment 3 2010-08-19 09:48:11 PDT

It's a "Not Implemented"/TODO comment.

Andrew Scherkus

Comment 4 2010-08-19 10:50:21 PDT

Comment on attachment 64778 [details] Patch WebKit/chromium/src/WebViewImpl.cpp:1516 + // Bring full screen window into focus if isFullscreen. ok in which case you should make this a // FIXME: Bring full screen blah blah blah ...

Bo Liu

Comment 5 2010-08-19 11:30:04 PDT

Created attachment 64879 [details] Update comment to FIXME

Adam Barth

Comment 6 2010-08-30 16:15:06 PDT

Comment on attachment 64879 [details] Update comment to FIXME This patch is missing a ChangeLog.

Stephen Chenney

Comment 7 2013-04-09 16:09:57 PDT

LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.

Note You need to log in before you can comment on or make changes to this bug.