Bug 44198

Summary:

[Chromium] m_downloadFilePath should be copied in WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	fishd: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-08-18 13:17:24 PDT

The m_downloadFilePath flag is currently not propagated correctly, because WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors don't copy it. We should fix that.

Attachments
patch (1.73 KB, patch) 2010-08-18 15:00 PDT, Dumitru Daniliuc	fishd: review+ dumi: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-08-18 15:00:56 PDT

Created attachment 64779 [details] patch

Dumitru Daniliuc

Comment 2 2010-08-18 15:47:05 PDT

landed: r65636.

WebKit Review Bot

Comment 3 2010-08-18 16:18:53 PDT

http://trac.webkit.org/changeset/65636 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/65635 http://trac.webkit.org/changeset/65636 http://trac.webkit.org/changeset/65637

Note You need to log in before you can comment on or make changes to this bug.