Summary: | [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor | ||
---|---|---|---|
Product: | WebKit | Reporter: | Nat Duca <nduca> |
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, fishd, nduca, vangelis, webkit.review.bot |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | All | ||
Attachments: |
Description
Nat Duca
2010-08-18 12:48:59 PDT
Created attachment 64770 [details]
Invalidate view when compositor activates
Created attachment 64896 [details]
Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect
Attachment 64896 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125: Missing space after , [whitespace/comma] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 64898 [details]
Make style bot happy
Attachment 64898 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125: Missing space after , [whitespace/comma] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
Looks reasonable to me, but I'm not an expert in this area.
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
Looks good on my side too. cq+ from me.
Comment on attachment 64903 [details] Trying again. Not my day for patch files, it seems. Rejecting patch 64903 from commit-queue. vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
One more try to get it to the commit queue.
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
with the flag set correctly this time :)
Comment on attachment 64903 [details] Trying again. Not my day for patch files, it seems. Rejecting patch 64903 from commit-queue. vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 64903 [details] Trying again. Not my day for patch files, it seems. Clearing flags on attachment: 64903 Committed r66450: <http://trac.webkit.org/changeset/66450> All reviewed patches have been landed. Closing bug. |