Bug 44160

Summary:

Web Inspector: make objectId of string type instead of object.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, bweinstein, eric, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	none

Pavel Feldman

Reported 2010-08-18 02:42:16 PDT

We'd like objectId to be 'string' on the protocol level. Patch to follow.

Attachments
[PATCH] Proposed change. (7.14 KB, patch) 2010-08-18 03:01 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-08-18 03:01:35 PDT

Created attachment 64679 [details] [PATCH] Proposed change.

Pavel Feldman

Comment 2 2010-08-18 03:09:39 PDT

Comment on attachment 64679 [details] [PATCH] Proposed change. Clearing flags on attachment: 64679 Committed r65597: <http://trac.webkit.org/changeset/65597>

Pavel Feldman

Comment 3 2010-08-18 03:09:49 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 4 2010-08-18 03:28:30 PDT

http://trac.webkit.org/changeset/65597 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597

Joseph Pecoraro

Comment 5 2010-08-18 09:43:54 PDT

Comment on attachment 64679 [details] [PATCH] Proposed change. > + parsedObjectId.id = parseInt(tokens[1]); > + return InjectedScriptAccess.get(parseInt(tokens[0])); I am always wary of parseInt() calls without a radix. Especially when user input may be involved. But I guess it is okay here. Just something to keep in mind.

Note You need to log in before you can comment on or make changes to this bug.