Summary: | [EFL] enable libsoup's content decode feature | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jaehun Lim <ljaehun.lim> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | CLOSED FIXED | ||||||||||
Severity: | Normal | CC: | antognolli+webkit, gyuyoung.kim, leandro, lucas.de.marchi, tonikitoo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Jaehun Lim
2010-08-17 19:04:32 PDT
Created attachment 64660 [details]
error screen
Created attachment 64661 [details]
Patch
Comment on attachment 64661 [details] Patch r=me > + [EFL] enable libsoup's content decode feature > + https://bugs.webkit.org/show_bug.cgi?id=44147 > + > + libsoup's content decode feature is enabled during initializaton. Please, rephrase to something like: "Enable libsoup's content decode feature..." or "Make libsoup's content decode feature is enabled during initializaton to fix web sites that send CSS encoded", blablabla. Something more descriptive. ps: When uploading the new patch , fill "Reviewed by" statement in the ChangeLog with "Antonio Gomes" and just set "cq?" to the patch. No need for a new > --- a/WebKit/efl/ewk/ewk_main.cpp > +++ b/WebKit/efl/ewk/ewk_main.cpp > @@ -125,6 +125,7 @@ int ewk_init(void) > if (1) { > SoupSession* session = WebCore::ResourceHandle::defaultSession(); > soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_SNIFFER); > + soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER); > } > #endif the if (1) above made me sad! :-( Created attachment 64670 [details]
Enable libsoup's content decode feature
OK. I upload a new patch.
Thanks for your review.
Comment on attachment 64661 [details] Patch Clearing flags on attachment: 64661 Committed r66038: <http://trac.webkit.org/changeset/66038> All reviewed patches have been landed. Closing bug. |