Bug 44147 – [EFL] enable libsoup's content decode feature

• Component: WebKit EFL
• Status: CLOSED FIXED

[Jaehun Lim]

WebKit-EFL does not support some gzip encoded contents.

See attached error screen.

Test site is mobile twitter login page. (https://mobile.twitter.com/session/new/)
 - CSS is not applied.

[Jaehun Lim]

Created attachment 64660 [details]
error screen

[Jaehun Lim]

Created attachment 64661 [details]
Patch

[Antonio Gomes]

Comment on attachment 64661 [details]
Patch

r=me

> +        [EFL] enable libsoup's content decode feature
> +        https://bugs.webkit.org/show_bug.cgi?id=44147
> +
> +        libsoup's content decode feature is enabled during initializaton.

Please, rephrase to something like: "Enable libsoup's content decode feature..." or "Make libsoup's content decode feature is enabled during initializaton to fix web sites that send CSS encoded", blablabla. Something more descriptive.

ps: When uploading the new patch , fill "Reviewed by" statement in the ChangeLog with "Antonio Gomes" and just set "cq?" to the patch. No need for a new 

> --- a/WebKit/efl/ewk/ewk_main.cpp
> +++ b/WebKit/efl/ewk/ewk_main.cpp
> @@ -125,6 +125,7 @@ int ewk_init(void)
>      if (1) {
>          SoupSession* session = WebCore::ResourceHandle::defaultSession();
>          soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_SNIFFER);
> +        soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
>      }
>  #endif  

the if (1) above made me sad! :-(

[Jaehun Lim]

Created attachment 64670 [details]
Enable libsoup's content decode feature

OK. I upload a new patch.

Thanks for your review.

[Lucas De Marchi]

Comment on attachment 64661 [details]
Patch

Clearing flags on attachment: 64661

Committed r66038: <http://trac.webkit.org/changeset/66038>

[Lucas De Marchi]

All reviewed patches have been landed.  Closing bug.