Summary: | [CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephen White <senorblanco> | ||||||
Component: | New Bugs | Assignee: | Stephen White <senorblanco> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, brettw, eric, fishd, jamesr, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Bug Depends on: | 44123 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Stephen White
2010-08-17 09:58:20 PDT
Created attachment 64602 [details]
Patch
Comment on attachment 64602 [details]
Patch
WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82
+ BitmapImageSingleFrameSkia(const SkBitmap&);
should this be marked 'explicit' just in case?
WebCore/platform/graphics/skia/NativeImageSkia.h:49
+ NativeImageSkia(const SkBitmap&);
nit: mark this 'explicit'?
R=me
(In reply to comment #2) > (From update of attachment 64602 [details]) > WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82 > + BitmapImageSingleFrameSkia(const SkBitmap&); > should this be marked 'explicit' just in case? > > WebCore/platform/graphics/skia/NativeImageSkia.h:49 > + NativeImageSkia(const SkBitmap&); > nit: mark this 'explicit'? Good idea. Will do before landing. > > R=me Committed r65528: <http://trac.webkit.org/changeset/65528> Rolled out in https://bugs.webkit.org/show_bug.cgi?id=44123 due to test failures; reopening. Created attachment 64627 [details]
Patch
Should fix the test failures (they go from 80 -> 40 on my Win7 box, which is about normal these days :| ). Comment on attachment 64627 [details]
Patch
R=me, but same comment about adding the 'explicit' keyword.
Committed r65617: <http://trac.webkit.org/changeset/65617> http://trac.webkit.org/changeset/65617 might have broken GTK Linux 32-bit Release |