Bug 44115

Summary:

[CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path.

Product:

WebKit

Reporter:

Stephen White <senorblanco>

Component:

New Bugs

Assignee:

Stephen White <senorblanco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, brettw, eric, fishd, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

44123

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	fishd: review+, fishd: commit-queue-

Stephen White

Reported 2010-08-17 09:58:20 PDT

[CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path.

Attachments
Patch (7.61 KB, patch) 2010-08-17 10:03 PDT, Stephen White	no flags	Details Formatted Diff Diff
Patch (7.63 KB, patch) 2010-08-17 13:54 PDT, Stephen White	fishd: review+ fishd: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Stephen White

Comment 1 2010-08-17 10:03:22 PDT

Created attachment 64602 [details] Patch

Darin Fisher (:fishd, Google)

Comment 2 2010-08-17 10:59:01 PDT

Comment on attachment 64602 [details] Patch WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82 + BitmapImageSingleFrameSkia(const SkBitmap&); should this be marked 'explicit' just in case? WebCore/platform/graphics/skia/NativeImageSkia.h:49 + NativeImageSkia(const SkBitmap&); nit: mark this 'explicit'? R=me

Stephen White

Comment 3 2010-08-17 11:03:40 PDT

(In reply to comment #2) > (From update of attachment 64602 [details]) > WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82 > + BitmapImageSingleFrameSkia(const SkBitmap&); > should this be marked 'explicit' just in case? > > WebCore/platform/graphics/skia/NativeImageSkia.h:49 > + NativeImageSkia(const SkBitmap&); > nit: mark this 'explicit'? Good idea. Will do before landing. > > R=me

Stephen White

Comment 4 2010-08-17 11:55:58 PDT

Committed r65528: <http://trac.webkit.org/changeset/65528>

Stephen White

Comment 5 2010-08-17 13:24:38 PDT

Rolled out in https://bugs.webkit.org/show_bug.cgi?id=44123 due to test failures; reopening.

Stephen White

Comment 6 2010-08-17 13:54:24 PDT

Created attachment 64627 [details] Patch

Stephen White

Comment 7 2010-08-17 14:01:40 PDT

Should fix the test failures (they go from 80 -> 40 on my Win7 box, which is about normal these days :| ).

Darin Fisher (:fishd, Google)

Comment 8 2010-08-18 10:38:31 PDT

Comment on attachment 64627 [details] Patch R=me, but same comment about adding the 'explicit' keyword.

Stephen White

Comment 9 2010-08-18 11:11:45 PDT

Committed r65617: <http://trac.webkit.org/changeset/65617>

WebKit Review Bot

Comment 10 2010-08-18 11:44:44 PDT

http://trac.webkit.org/changeset/65617 might have broken GTK Linux 32-bit Release

Note You need to log in before you can comment on or make changes to this bug.