Summary: | [GTK] GSettings support adds annoying warnings on systems with older glib versions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2010-08-16 07:23:53 PDT
Created attachment 64493 [details]
proposed fix
Comment on attachment 64493 [details]
proposed fix
I'm not sure if this review is necessary, but the EWS is green so LGTM!
Comment on attachment 64493 [details]
proposed fix
\o/
Comment on attachment 64493 [details] proposed fix Rejecting patch 64493 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 2 Last 500 characters of output: ChangeLog patching file WebKit/gtk/ChangeLog patching file WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp patching file WebKit/gtk/webkit/webkitprivate.cpp patching file WebKit/gtk/webkit/webkitprivate.h patching file autotools/gsettings.m4 The following paths are ignored by one of your .gitignore files: autotools Use -f if you really want to add them. fatal: no files added Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427. Full output: http://queues.webkit.org/results/3718273 (In reply to comment #4) > patching file autotools/gsettings.m4 > The following paths are ignored by one of your .gitignore files: > autotools > Use -f if you really want to add them. > fatal: no files added > Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427. > > Full output: http://queues.webkit.org/results/3718273 That's because .gitignore is casting the net too wide (ignoring the whole autotools directory). I'll make it more selective so this doesn't happen again =). |