Bug 4405 – <button> not listed in form collections.

• Component: DOM
• Status: RESOLVED FIXED

[Maks Orlovich]

Hi.. Looks like you folks also have the KDE bug #110629, <button> 
not included in form elements collection. Will attach testcase and the obvious 
patch (against kde svn, don't have a mac)

[Maks Orlovich]

Created attachment 3353 [details]
Testcase

Testcase (khtmltests/regression/tests/ecma/form-collect-button-110629.html)
FFox, WinIE, and MacIE all find the <button>

[Maks Orlovich]

The following obvious change fixes it: 
maksim@treetop khtml]$ ~/kde3/kdesdk/scripts/svnlastchange 
html/html_formimpl.h 
------------------------------------------------------------------------ 
r446120 | orlovich | 2005-08-12 11:31:46 -0400 (Fri, 12 Aug 2005) | 4 lines 
 
<button> belongs in form collections, too. Testcase based on the report 
upcoming. 
BUG:110629 
 
------------------------------------------------------------------------ 
Index: html/html_formimpl.h 
=================================================================== 
--- html/html_formimpl.h        (revision 446119) 
+++ html/html_formimpl.h        (revision 446120) 
@@ -196,6 +196,7 @@ public: 
     }; 
 
     virtual Id id() const; 
+    virtual bool isEnumeratable() const { return true; } 
 
     DOMString type() const; 
     typeEnum buttonType() const { return m_type; } 
 

[Maciej Stachowiak]

Created attachment 5298 [details]
Maks's fix in patch form, with test case

[Maciej Stachowiak]

Comment on attachment 5298 [details]
Maks's fix in patch form, with test case

r=me on Maks's fix.