Summary: | HTML5 fragment parsing doesn't load iframes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
The problem is that Document::adoptNode is calling setRemainsAliveOnRemovalFromTree and confusing the frame. I think we're supposed to construct the fragment completely detached but somehow it's getting attached? Fragments shouldn't get attached at all. I suspect we have a bug in HTMLConstructionSite. Created attachment 64465 [details]
Patch
Comment on attachment 64465 [details]
Patch
r=me
The test output doesn't really make it obvious that it's a pass. Did you intent to keep the numbered alerts in?
Created attachment 64473 [details]
Patch for landing
Comment on attachment 64473 [details] Patch for landing Clearing flags on attachment: 64473 Committed r65396: <http://trac.webkit.org/changeset/65396> All reviewed patches have been landed. Closing bug. Comment on attachment 64473 [details]
Patch for landing
Thanks. I agree the test output is a bit confusing. :) But I've very glad for the bug fix!
|
Created attachment 64454 [details] reduced test case This is causing some layout test failures with --html5-treebuilder turned on. I've attached a reduction.