Bug 44029

Summary: Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: loislo, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed change.
yurys: review-
[PATCH] Reviewer comments addressed.
yurys: review+
[PATCH] Same with DRT. none

Description Pavel Feldman 2010-08-15 05:47:57 PDT
Now that we populate front-end after its onload handler, I don't think we need to install injected script early.
Comment 1 Pavel Feldman 2010-08-15 05:52:46 PDT
Created attachment 64446 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-08-16 01:19:22 PDT
Comment on attachment 64446 [details]
[PATCH] Proposed change.

 +          to install injected script early.
InjectedScript source isn't pushed when inspected tab is navigated to a different domain and because of that resides in a new render process(we won't send the script source to that process).
Comment 3 Pavel Feldman 2010-08-19 03:25:27 PDT
Created attachment 64825 [details]
[PATCH] Reviewer comments addressed.
Comment 4 Pavel Feldman 2010-08-19 07:17:56 PDT
Created attachment 64845 [details]
[PATCH] Same with DRT.
Comment 5 Pavel Feldman 2010-08-19 07:48:28 PDT
Comment on attachment 64845 [details]
[PATCH] Same with DRT.

Clearing flags on attachment: 64845

Committed r65669: <http://trac.webkit.org/changeset/65669>
Comment 6 Pavel Feldman 2010-08-19 07:48:41 PDT
All reviewed patches have been landed.  Closing bug.