Bug 44029

Summary: Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: loislo, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
yurys: review-
[PATCH] Reviewer comments addressed.
yurys: review+
[PATCH] Same with DRT. none

Pavel Feldman
Reported 2010-08-15 05:47:57 PDT
Now that we populate front-end after its onload handler, I don't think we need to install injected script early.
Attachments
[PATCH] Proposed change. (2.53 KB, patch)
2010-08-15 05:52 PDT, Pavel Feldman 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] Reviewer comments addressed. (5.03 KB, patch)
2010-08-19 03:25 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
[PATCH] Same with DRT. (8.63 KB, patch)
2010-08-19 07:17 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-15 05:52:46 PDT
Created attachment 64446 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2010-08-16 01:19:22 PDT
Comment on attachment 64446 [details] [PATCH] Proposed change. WebKit/chromium/ChangeLog:7 + to install injected script early. InjectedScript source isn't pushed when inspected tab is navigated to a different domain and because of that resides in a new render process(we won't send the script source to that process).
Pavel Feldman
Comment 3 2010-08-19 03:25:27 PDT
Created attachment 64825 [details] [PATCH] Reviewer comments addressed.
Pavel Feldman
Comment 4 2010-08-19 07:17:56 PDT
Created attachment 64845 [details] [PATCH] Same with DRT.
Pavel Feldman
Comment 5 2010-08-19 07:48:28 PDT
Comment on attachment 64845 [details] [PATCH] Same with DRT. Clearing flags on attachment: 64845 Committed r65669: <http://trac.webkit.org/changeset/65669>
Pavel Feldman
Comment 6 2010-08-19 07:48:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.