Summary: | XSLTProcessor.transformToFragment should not pass contextElement to the parser (since there is no context) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-08-14 16:00:33 PDT
Created attachment 64432 [details]
Patch
Comment on attachment 64432 [details]
Patch
WebCore/xml/XSLTProcessor.cpp:103
+ fragment->parseHTML(sourceString, 0);
I don't get this part of the change. Who passes a non-zero argument?
Comment on attachment 64432 [details]
Patch
Thanks for explaining on IRC. We should probably have two methods with different names since they're semantically different.
the contextElement is an optional parameter to the parse (at least in HTML5). The Xml parser should work similarly. Comment on attachment 64432 [details] Patch Clearing flags on attachment: 64432 Committed r65375: <http://trac.webkit.org/changeset/65375> All reviewed patches have been landed. Closing bug. |