Bug 44011

Summary: Move innerHTML off of Range::createContextualFragment
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2010-08-14 09:23:15 PDT
Move innerHTML off of Range::createContextualFragment
Attachments
Patch (12.55 KB, patch)
2010-08-14 09:40 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (13.86 KB, patch)
2010-08-14 14:02 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-08-14 09:40:51 PDT
Created attachment 64419 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-14 09:42:27 PDT
diff seems to have made this patch way more confusing than it needs to be. This is all just removing html5TreeBuilder if blocks around some code in createContextualFragment, and adding new if blocks in innerHTML and outerHTML.
Eric Seidel (no email)
Comment 3 2010-08-14 11:11:55 PDT
Comment on attachment 64419 [details] Patch This instead broke the XML innerHTML code path. Will fix.
Eric Seidel (no email)
Comment 4 2010-08-14 14:02:08 PDT
Created attachment 64427 [details] Patch
Adam Barth
Comment 5 2010-08-14 14:05:29 PDT
Comment on attachment 64427 [details] Patch Ok. These stuff is somewhat messy after this patch (ok, it was messy before), but we're making progress.
WebKit Commit Bot
Comment 6 2010-08-14 14:39:14 PDT
Comment on attachment 64427 [details] Patch Clearing flags on attachment: 64427 Committed r65372: <http://trac.webkit.org/changeset/65372>
WebKit Commit Bot
Comment 7 2010-08-14 14:39:18 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-08-14 14:51:45 PDT
http://trac.webkit.org/changeset/65372 might have broken Qt Linux Release minimal
Note You need to log in before you can comment on or make changes to this bug.