Bug 43997

Summary:

add ability to test order-of-magnitude performance in layout tests

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, dpranke, eric, mjs, noel.gordon, rniwa, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Ojan Vafai

Reported 2010-08-13 16:48:34 PDT

add ability to test order-of-magnitude in layout tests

Attachments
Patch (19.08 KB, patch) 2010-08-13 16:56 PDT, Ojan Vafai	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2010-08-13 16:56:01 PDT

Created attachment 64389 [details] Patch

Dirk Pranke

Comment 2 2010-08-13 17:28:15 PDT

I'm glad these tests work they way they do, but the ChangeLog gives little insight into how or why you're doing these tests. Is it your intent to have the magnitude script be used by various perf tests to test expected performance? Should there be a page on webkit.org or something explaining this? Maybe at least a reference to magnitude-perf.js should be included into the ChangeLog?

Ojan Vafai

Comment 3 2010-08-13 17:32:40 PDT

(In reply to comment #2) > Is it your intent to have the magnitude script be used by various perf tests to test expected performance? Yes. There's precedent for this kind of testing with dump-as-markup.js. > Should there be a page on webkit.org or something explaining this? Eventually yes. For now, I want to get it reviewed and into the code base and have a few people other than me write some tests to work out the kinks. Then I'll write something up and email webkit-dev.

Dirk Pranke

Comment 4 2010-08-13 17:34:43 PDT

groovy :)

Ojan Vafai

Comment 5 2010-08-18 10:35:03 PDT

Committed r65614: <http://trac.webkit.org/changeset/65614>

noel gordon

Comment 6 2012-01-04 18:05:56 PST

perf/array-reverse.html seems flaky http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=perf%2Farray-reverse.html

Tony Chang

Comment 7 2012-01-05 10:28:20 PST

Marked flaky in http://trac.webkit.org/changeset/104177 .

Note You need to log in before you can comment on or make changes to this bug.