Bug 43990

Summary: Add dictionary API type
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch beidson: review+

Description Sam Weinig 2010-08-13 13:57:17 PDT
Add dictionary API type.
Comment 1 Sam Weinig 2010-08-13 13:59:20 PDT
Created attachment 64374 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-13 14:00:08 PDT
Attachment 64374 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:64:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:79:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WebKit2.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/Shared/ImmutableDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-13 14:33:51 PDT
Landed in r65339.