Bug 43977

Summary: Web Inspector: Inspector tests were disabled for GTK.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, eric, joepeck, keishi, mrobinson, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 43791    
Bug Blocks:    
Attachments:
Description Flags
Patch adding support for setting web inspector path via an environment variable pfeldman: review+

Ilya Tikhonovsky
Reported 2010-08-13 08:40:46 PDT
Hand written InspectorBackendStub.js was replaced with generated one. It was removed from WebCore/inspector/front-end/ and is generating into DerivedSources/webcore. Gtk version of DumpRenderTree can't handle this because it is loading inspector directly from the sources. The full set of inspector files is generating into $(WEBKITOUTPUTDIR)/Programs/resources/inspector. InspectorClientGtk should use that location.
Attachments
Patch adding support for setting web inspector path via an environment variable (8.04 KB, patch)
2010-08-19 08:57 PDT, Martin Robinson 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-08-19 08:57:35 PDT
Created attachment 64858 [details] Patch adding support for setting web inspector path via an environment variable
Ilya Tikhonovsky
Comment 2 2010-08-20 02:21:08 PDT
Comment on attachment 64858 [details] Patch adding support for setting web inspector path via an environment variable Looks good to me
Pavel Feldman
Comment 3 2010-08-20 02:22:36 PDT
Comment on attachment 64858 [details] Patch adding support for setting web inspector path via an environment variable Thanks for fixing this.
Martin Robinson
Comment 4 2010-08-20 09:35:26 PDT
Committed r65737: <http://trac.webkit.org/changeset/65737>
WebKit Review Bot
Comment 5 2010-08-20 10:03:44 PDT
http://trac.webkit.org/changeset/65737 might have broken GTK Linux 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.