Bug 43977 - Web Inspector: Inspector tests were disabled for GTK.
Summary: Web Inspector: Inspector tests were disabled for GTK.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 43791
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-13 08:40 PDT by Ilya Tikhonovsky
Modified: 2010-08-20 10:03 PDT (History)
12 users (show)

See Also:

Attachments
Patch adding support for setting web inspector path via an environment variable (8.04 KB, patch)
2010-08-19 08:57 PDT, Martin Robinson 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-08-13 08:40:46 PDT 
Hand written InspectorBackendStub.js was replaced with generated one.
It was removed from WebCore/inspector/front-end/ and is generating into DerivedSources/webcore.
Gtk version of DumpRenderTree can't handle this because it is loading inspector directly from the sources.
The full set of inspector files is generating into $(WEBKITOUTPUTDIR)/Programs/resources/inspector.
InspectorClientGtk should use that location.
Comment 1 Martin Robinson 2010-08-19 08:57:35 PDT 
Created attachment 64858 [details]
Patch adding support for setting web inspector path via an environment variable
Comment 2 Ilya Tikhonovsky 2010-08-20 02:21:08 PDT 
Comment on attachment 64858 [details]
Patch adding support for setting web inspector path via an environment variable

Looks good to me
Comment 3 Pavel Feldman 2010-08-20 02:22:36 PDT 
Comment on attachment 64858 [details]
Patch adding support for setting web inspector path via an environment variable

Thanks for fixing this.
Comment 4 Martin Robinson 2010-08-20 09:35:26 PDT 
Committed r65737: <http://trac.webkit.org/changeset/65737>
Comment 5 WebKit Review Bot 2010-08-20 10:03:44 PDT 
http://trac.webkit.org/changeset/65737 might have broken GTK Linux 32-bit Release