Bug 43966

Summary: Web Inspector: rename InspectorValue::push and set to push{Value|Object|Array} and set{...}.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
none
[PATCH] Review comments addressed.
none
[PATCH] Proposed change. none

Description Pavel Feldman 2010-08-13 05:57:47 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-08-13 05:59:39 PDT
Created attachment 64329 [details]
[PATCH] Proposed change.
Comment 2 Ilya Tikhonovsky 2010-08-13 06:06:10 PDT
Comment on attachment 64329 [details]
[PATCH] Proposed change.

WebCore/inspector/CodeGeneratorInspector.pm: 
 +          my $argumentType = $typeTransform{$type}->{$typeTransform{$typetype}->{"retVal"} ? "retVal" : "variable"};
Looks like retVal argument is not used any more.

LGTM
Comment 3 Pavel Feldman 2010-08-13 06:06:25 PDT
Created attachment 64331 [details]
[PATCH] Review comments addressed.
Comment 4 Eric Seidel (no email) 2010-08-13 06:13:06 PDT
Attachment 64329 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3759118
Comment 5 Ilya Tikhonovsky 2010-08-13 06:15:04 PDT
Comment on attachment 64331 [details]
[PATCH] Review comments addressed.

WebCore/inspector/InspectorValues.cpp:513
 +  bool InspectorValue::asObject(RefPtr<InspectorObject>* output)
will not compile on MAC
Comment 6 Pavel Feldman 2010-08-13 06:16:44 PDT
Created attachment 64332 [details]
[PATCH] Proposed change.

Thanks for the hint, Ilya!
Comment 7 Eric Seidel (no email) 2010-08-13 06:22:07 PDT
Attachment 64331 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3706112
Comment 8 Pavel Feldman 2010-08-13 06:22:43 PDT
Comment on attachment 64332 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 64332

Committed r65320: <http://trac.webkit.org/changeset/65320>
Comment 9 Pavel Feldman 2010-08-13 06:22:55 PDT
All reviewed patches have been landed.  Closing bug.