Summary: | [Chromium] styled scroll bar on the window is painted badly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, hyatt | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Hajime Morrita
2010-08-13 02:28:29 PDT
Created attachment 64317 [details]
Patch
Comment on attachment 64317 [details]
Patch
I am not sure if this is a good patch (not yet that knowledgeable about the mechanics here :), but here are a few nits:
WebCore/ChangeLog:15
+ (WebCore::RenderObject::hasBackground):
Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah".
WebCore/rendering/RenderScrollbar.cpp:144
+ void RenderScrollbar::adjustStyle(RenderStyle* style) const
Why a separate method for this? It's only being used in one place and it's short enough to inline, I think?
WebCore/rendering/RenderScrollbar.cpp:149
+ // causes visual artifact like non-repainted durty region.
"painted" and "dirty".
Created attachment 64464 [details]
Patch
Hi Dimitri, thank you for reviewing! I updated the patch. > WebCore/ChangeLog:15 > + (WebCore::RenderObject::hasBackground): > Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah". OK, added some explanation. Thank you for pointing this out. > > WebCore/rendering/RenderScrollbar.cpp:144 > + void RenderScrollbar::adjustStyle(RenderStyle* style) const > Why a separate method for this? It's only being used in one place and it's short enough to inline, I think? > Agreed and inlined. > WebCore/rendering/RenderScrollbar.cpp:149 > + // causes visual artifact like non-repainted durty region. > "painted" and "dirty". Oops. Fixed. Comment on attachment 64464 [details]
Patch
The patch looks reasonable. I'll set r+ tomorrow if no one objects.
Committed r66372: <http://trac.webkit.org/changeset/66372> |