Bug 43957

Summary:

Need a LayoutTest to check that pages using Geolocation are not put in the page cache

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

39879

Attachments:

Description	Flags
Patch	ap: review+

Steve Block

Reported 2010-08-13 01:40:11 PDT

Currently, pages that use Geolocation are explicitly prevented from entering the page cache. This is planned to be fixed in Bug 43956 but until then, we should add a test to make sure that such pages do no enter the page cache.

Attachments
Patch (5.18 KB, patch) 2010-08-13 02:07 PDT, Steve Block	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-08-13 02:07:36 PDT

Created attachment 64314 [details] Patch

Alexey Proskuryakov

Comment 2 2010-08-13 02:25:53 PDT

Comment on attachment 64314 [details] Patch As mentioned elsewhere, having a separate JS file is harmful in several ways. This is not grounds for r-, since many existing tests do the same, but I think that we should stop doing that, and maybe even convert existing tests. +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode (if needed).

Steve Block

Comment 3 2010-08-13 08:57:16 PDT

> The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode > (if needed). I don't think we need strict mode here. However, this DOCTYPE comes from TEMPLATE.html for the Geolocation tests. Looking at other TEMPLATE.html files, almost all specify a DOCTYPE [1] and of those, all but two [2] use this HTML2 DOCTYPE. I could file a bug to change or remove the DOCTYPE for all Geolocation tests. [1] No DOCTYPE ... fast/dom/DeviceMotion/script-tests/TEMPLATE.html fast/dom/DeviceOrientation/script-tests/TEMPLATE.html storage/domstorage/events/script-tests/TEMPLATE.html storage/domstorage/script-tests/TEMPLATE.html storage/indexeddb/script-tests/TEMPLATE.html [2] HTML5 DOCTYPE ... platform/win/editing/selection/script-tests/TEMPLATE.html platform/mac/editing/selection/script-tests/TEMPLATE.html

Steve Block

Comment 4 2010-08-13 09:24:07 PDT

Committed r65325: <http://trac.webkit.org/changeset/65325>

Note You need to log in before you can comment on or make changes to this bug.