Summary: | Need a LayoutTest to check that pages using Geolocation are not put in the page cache | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 39879 | ||||||
Attachments: |
|
Description
Steve Block
2010-08-13 01:40:11 PDT
Created attachment 64314 [details]
Patch
Comment on attachment 64314 [details]
Patch
As mentioned elsewhere, having a separate JS file is harmful in several ways. This is not grounds for r-, since many existing tests do the same, but I think that we should stop doing that, and maybe even convert existing tests.
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode (if needed).
> The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode
> (if needed).
I don't think we need strict mode here. However, this DOCTYPE comes from TEMPLATE.html for the Geolocation tests. Looking at other TEMPLATE.html files, almost all specify a DOCTYPE [1] and of those, all but two [2] use this HTML2 DOCTYPE.
I could file a bug to change or remove the DOCTYPE for all Geolocation tests.
[1] No DOCTYPE ...
fast/dom/DeviceMotion/script-tests/TEMPLATE.html
fast/dom/DeviceOrientation/script-tests/TEMPLATE.html
storage/domstorage/events/script-tests/TEMPLATE.html
storage/domstorage/script-tests/TEMPLATE.html
storage/indexeddb/script-tests/TEMPLATE.html
[2] HTML5 DOCTYPE ...
platform/win/editing/selection/script-tests/TEMPLATE.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
Committed r65325: <http://trac.webkit.org/changeset/65325> |