Summary: | REGRESSION(r65181): It broke 35 layout tests fail on chromium-win (Requested by hamaji on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dimich, eric, hamaji, jhawkins | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 44168 | ||||||
Bug Blocks: | 43648 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2010-08-12 05:26:19 PDT
Created attachment 64212 [details] ROLLOUT of r65181 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. Interestingly, it didn't fail on canary nor trybot, but the following URLs says this revision broke these tests. http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26011 http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26012 Committed r65238: <http://trac.webkit.org/changeset/65238> Comment on attachment 64212 [details] ROLLOUT of r65181 Rejecting patch 64212 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file WebKit/chromium/public/WebFrameClient.h Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebFrameClient.h.rej patching file WebKit/chromium/src/FrameLoaderClientImpl.cpp Hunk #1 FAILED at 248. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/FrameLoaderClientImpl.cpp.rej Full output: http://queues.webkit.org/results/3709091 I've heard that this type of bot failures may be fixed by clobbering. I'll try re-reverting this patch when Chromium's WebKit revision is up-to-date. Unfortunately, non-PST WebKit roll has not been done yet, so I'll check this tomorrow again. Re-landed in: http://trac.webkit.org/changeset/65604 It seems clobber build worked! (In reply to comment #6) > Re-landed in: http://trac.webkit.org/changeset/65604 > > It seems clobber build worked! Does that mean we've filed a bug about the build system problem? :) (In reply to comment #7) > (In reply to comment #6) > > Re-landed in: http://trac.webkit.org/changeset/65604 > > > > It seems clobber build worked! > > Does that mean we've filed a bug about the build system problem? :) Done :) http://code.google.com/p/chromium/issues/detail?id=52693 |