Bug 43907

Summary:

V8 code generator does not add V8BindingMacros.h include in all places it is needed

Product:

WebKit

Reporter:

Ben Murdoch <benm>

Component:

WebCore Misc.

Assignee:

Ben Murdoch <benm>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, commit-queue, dumi, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	none

Ben Murdoch

Reported 2010-08-12 05:00:18 PDT

V8BindingMacros.h was added in http://trac.webkit.org/changeset/65005 and defines two macros: EXCEPTION_BLOCK and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK. In the V8 CodeGenerator, we push this header when we generate code using EXCEPTION_BLOCK, but not STRING_TO_V8PARAMETER_EXCEPTION_BLOCK (see http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1233 and http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1240) Patch to follow.

Attachments
Patch. (1.55 KB, patch) 2010-08-12 05:22 PDT, Ben Murdoch	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-08-12 05:04:46 PDT

Thanks for catching this problem, and sorry I didn't notice it when changing that code...

Ben Murdoch

Comment 2 2010-08-12 05:22:34 PDT

Ben Murdoch

Comment 3 2010-08-12 05:23:23 PDT

(In reply to comment #1) > Thanks for catching this problem, and sorry I didn't notice it when changing that code... No problem!

Steve Block

Comment 4 2010-08-12 05:51:57 PDT

WebKit Commit Bot

Comment 5 2010-08-12 06:28:18 PDT

Comment on attachment 64211 [details] Patch. Clearing flags on attachment: 64211 Committed r65240: <http://trac.webkit.org/changeset/65240>

WebKit Commit Bot

Comment 6 2010-08-12 06:28:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.