Bug 43897

Summary: The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, barraclough, commit-queue, eric, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 none

Gabor Loki
Reported 2010-08-12 00:37:06 PDT
The asserts in JITThunks::JITThunks complain about the wrong offset values.
Attachments
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 (2.87 KB, patch)
2010-08-12 01:10 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2010-08-12 01:10:46 PDT
Created attachment 64191 [details] Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 A 64 bits wide data is aligned to 8 bytes on ARM by default, but the ..._OFFSET macros in JITStubs.cpp are calculated as the args member is started from the fourth byte. So, the macros are updated and the type of reserved member is replaced with JITStubArg, in order not to make any mistake about the offsets.
Gavin Barraclough
Comment 2 2010-08-13 01:01:33 PDT
Hey Gabor, looks good but I'd like to test this patch doesn't break anything on darwin. I'll test tomorrow morning & land assuming all is good.
Gavin Barraclough
Comment 3 2010-08-18 01:48:13 PDT
Comment on attachment 64191 [details] Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 All good!
WebKit Commit Bot
Comment 4 2010-08-18 03:03:37 PDT
Comment on attachment 64191 [details] Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 Clearing flags on attachment: 64191 Committed r65596: <http://trac.webkit.org/changeset/65596>
WebKit Commit Bot
Comment 5 2010-08-18 03:03:41 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-08-18 03:28:22 PDT
http://trac.webkit.org/changeset/65596 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597
Note You need to log in before you can comment on or make changes to this bug.