Summary: | The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gabor Loki <loki> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | abarth, barraclough, commit-queue, eric, webkit.review.bot | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Gabor Loki
2010-08-12 00:37:06 PDT
Created attachment 64191 [details]
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64
A 64 bits wide data is aligned to 8 bytes on ARM by default, but the ..._OFFSET macros in JITStubs.cpp are calculated as the args member is started from the fourth byte.
So, the macros are updated and the type of reserved member is replaced with JITStubArg, in order not to make any mistake about the offsets.
Hey Gabor, looks good but I'd like to test this patch doesn't break anything on darwin. I'll test tomorrow morning & land assuming all is good. Comment on attachment 64191 [details]
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64
All good!
Comment on attachment 64191 [details] Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 Clearing flags on attachment: 64191 Committed r65596: <http://trac.webkit.org/changeset/65596> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/65596 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597 |